This repository has been archived by the owner on May 13, 2023. It is now read-only.
feat: add realtimeClientOptions to SupabaseClient
#173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshukertjr
changed the title
dshukertjr
commented
Feb 1, 2023
| params: {'apikey': supabaseKey}, | ||
| params: { | ||
| 'apikey': supabaseKey, | ||
| if (eventsPerSecond != null) 'eventsPerSecond': '$eventsPerSecond' |
There was a problem hiding this comment.
eventsPerSecond is expected to be a String here for some reason.
dshukertjr
requested review from
Vinzent03 and
bdlukaa
and removed request for
bdlukaa and
Vinzent03
Vinzent03
approved these changes
Feb 3, 2023
dshukertjr
changed the title
realtimeClientOptions to SupabaseClient
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Realtime client has a eventsPerSecond parameter, that can be overridden by passing it to the
paramsparameter on the constructore ofRealtimeClient.This PR adds a new
realtimeClientOptionsparameter of typeRealtimeClientOptionsto theSupabaseClientconstructor and addseventsPerSecondparameter.Other context
I'm working on a realtime gaming app using Supabase and Flame, and with because of not being able to override
eventsPerSecond, I can only send broadcast events 10 times a second, which makes the game feel not so smooth. Adding this option and bringing the eventsPerSecond up to 30 made it look very smoooth.