Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resize type on signed url #285

Merged
merged 1 commit into from
Mar 6, 2023
Merged

fix: resize type on signed url #285

merged 1 commit into from
Mar 6, 2023

Conversation

fenos
Copy link
Contributor

@fenos fenos commented Mar 6, 2023

What kind of change does this PR introduce?

Bug fix

What is the new behavior?

  • Resize type is now respected on signed rendered urls
  • Integer first in validation param validation

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4341949425

  • 49 of 56 (87.5%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.06%) to 85.326%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/storage/renderer/image.ts 43 50 86.0%
Files with Coverage Reduction New Missed Lines %
src/storage/renderer/image.ts 1 78.11%
Totals Coverage Status
Change from base Build 4233519537: 0.06%
Covered Lines: 5116
Relevant Lines: 5963

💛 - Coveralls

@fenos fenos merged commit 028d770 into master Mar 6, 2023
@fenos fenos deleted the fix/resize-type-img-url branch March 6, 2023 15:26
@github-actions
Copy link

github-actions bot commented Mar 6, 2023

🎉 This PR is included in version 0.29.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants