feat: added methods for signed-url upload #152
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rawnly Thanks a lot for the PR i will take over!! Much appreciated it!! |
This was referenced Apr 7, 2023
Closed
fenix-hub
added a commit
to supabase-community/godot-engine.supabase
that referenced
this pull request
Apr 10, 2023
Merged
|
@inian awesome! Happy to help ✌️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Adds support for
signed-urlupload as introduced inv0.30.0via supabase/storage#282What is the current behavior?
No method is provided.
What is the new behavior?
Expose the
createUploadSignedUrlanduploadToSignedUrlmethodsAdditional context
Tests aren't passing, I'm sure something is wrong with the environment.
I'm open to suggestions / improvements.
400 - The parent resource is not foundI'm also aware that method names aren't the best but I wanted to do a POC to see if this is relevant to you.
An improvement could be using function overloading to avoid method duplication.