Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore envs declared with empty value #3062

Merged
merged 1 commit into from
Jan 22, 2025
Merged

fix: ignore envs declared with empty value #3062

merged 1 commit into from
Jan 22, 2025

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Jan 22, 2025

What kind of change does this PR introduce?

Bug fix

What is the new behavior?

If user declares an empty value in .env like MY_SECRET=, we should treat them as uninitialised like we used to.

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge requested a review from a team as a code owner January 22, 2025 07:27
@sweatybridge sweatybridge merged commit 7c26c04 into develop Jan 22, 2025
8 checks passed
@sweatybridge sweatybridge deleted the fix-env branch January 22, 2025 07:37
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12903299947

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 58.239%

Files with Coverage Reduction New Missed Lines %
internal/storage/rm/rm.go 2 89.53%
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 12899221402: -0.02%
Covered Lines: 7592
Relevant Lines: 13036

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants