Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: defaults to json when initialising import map #3038

Merged
merged 1 commit into from
Jan 13, 2025
Merged

fix: defaults to json when initialising import map #3038

merged 1 commit into from
Jan 13, 2025

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Jan 13, 2025 •
edited
Loading

What kind of change does this PR introduce?

Bug fix

What is the new behavior?

Since edge runtime doesn't yet support jsonc, we will initialise new functions with default deno.json instead.

Existing .jsonc files can still be used as import map if they contain no comments.

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge requested a review from a team as a code owner January 13, 2025 16:38
@coveralls
Copy link

coveralls commented Jan 13, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12751883708

Details

  • 10 of 16 (62.5%) changed or added relevant lines in 2 files are covered.
  • 7 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.02%) to 58.421%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/functions/new/new.go 1 2 50.0%
internal/functions/deploy/deploy.go 9 14 64.29%
Files with Coverage Reduction New Missed Lines %
internal/functions/new/new.go 1 88.57%
internal/functions/deploy/deploy.go 1 79.81%
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 12741908425: -0.02%
Covered Lines: 7572
Relevant Lines: 12961
💛 - Coveralls

@sweatybridge sweatybridge changed the title fix: defaults to json import map fix: defaults to json when initialising import map Jan 13, 2025
@sweatybridge sweatybridge merged commit f9f9d95 into develop Jan 13, 2025
9 checks passed
@sweatybridge sweatybridge deleted the drop-jsonc branch January 13, 2025 16:59
@github-actions github-actions bot mentioned this pull request Feb 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sweatybridge @coveralls