Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up packaging after Poetry adoption #551

Merged
merged 2 commits into from
Oct 23, 2020
Merged

Clean up packaging after Poetry adoption #551

merged 2 commits into from
Oct 23, 2020

Conversation

haxoza
Copy link
Member

@haxoza haxoza commented Oct 22, 2020

Changes in this commit:

  • Remove not used pipenv based files
  • Remove dangling requirements.txt file
  • Remove not used Manifest.in and setup.cfg file, which covered by
    poetry
  • Move flake8 config from setup.cfg to tox.ini file
  • Include fuzzy translations in make build command
  • Include *.mo files in final build

Refs #544

Changes in this commit:

* Remove not used pipenv based files
* Remove dangling requirements.txt file
* Remove not used Manifest.in and setup.cfg file, which covered by
poetry
* Move flake8 config from setup.cfg to tox.ini file
* Include fuzzy translations in `make build` command
* Include *.mo files in final build

Refs #544
@haxoza haxoza requested review from dekoza and tomwojcik October 22, 2020 12:45
@codecov
Copy link

codecov bot commented Oct 22, 2020

Codecov Report

Merging #551 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #551   +/-   ##
=======================================
  Coverage   98.95%   98.95%           
=======================================
  Files          19       19           
  Lines         670      670           
=======================================
  Hits          663      663           
  Misses          7        7           
Impacted Files Coverage Δ
djoser/social/urls.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfd96c0...d469351. Read the comment docs.

Copy link
Contributor

@tomwojcik tomwojcik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's always good to remove some code. LGTM

@haxoza haxoza merged commit eea3e99 into master Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants