Adds isort and codespell to pre-commit #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyclingNinja
added a commit
to CyclingNinja/package-template
that referenced
this pull request
Feb 28, 2024
* Update {{ cookiecutter.package_name }}/.github/workflows/sub_package_update.yml
Co-authored-by: Stuart Mumford <[email protected]>
* Upstreaming lessons from SunPy application
* Apply suggestions from code review
---------
Co-authored-by: Stuart Mumford <[email protected]>
for more information, see https://pre-commit.ci
nabobalis
reviewed
Feb 28, 2024
Comment on lines
3
to
5
| {%- if cookiecutter.include_example_code == 'y' %} | ||
| from .example_mod import do_primes | ||
| {%- if cookiecutter.include_example_code == 'y' %} | ||
| # Then you can be explicit to control what ends up in the namespace, |
There was a problem hiding this comment.
Going to need to make sure isort doesnt move this with # isort:skip ?
There was a problem hiding this comment.
yeah this is what i'm trying to sort atm 😞
CyclingNinja
force-pushed
the
pre_commit_additions
branch
3 times, most recently
from
13754e5 to
d84b458
Compare
…e-template into pre_commit_additions
CyclingNinja
force-pushed
the
pre_commit_additions
branch
from
d84b458 to
2c36596
Compare
Cadair
reviewed
Mar 1, 2024
{{ cookiecutter.package_name }}/{{ cookiecutter.module_name }}/__init__.py
Outdated
Show resolved
Hide resolved
{{ cookiecutter.package_name }}/{{ cookiecutter.module_name }}/example_mod.py
Outdated
Show resolved
Hide resolved
Cadair
reviewed
Mar 1, 2024
{{ cookiecutter.package_name }}/{{ cookiecutter.module_name }}/__init__.py
Outdated
Show resolved
Hide resolved
Cadair
reviewed
Mar 1, 2024
{{ cookiecutter.package_name }}/{{ cookiecutter.module_name }}/__init__.py
Outdated
Show resolved
Hide resolved
…/__init__.py Co-authored-by: Stuart Mumford <[email protected]>
…/__init__.py Co-authored-by: Stuart Mumford <[email protected]>
Cadair
reviewed
Mar 1, 2024
nabobalis
reviewed
Mar 1, 2024
| @@ -14,3 +14,5 @@ repos: | |||
| exclude: "{{ cookiecutter.package_name }}" | |||
| - id: debug-statements | |||
| exclude: "{{ cookiecutter.package_name }}" | |||
| ci: | |||
| autofix_prs: false | |||
There was a problem hiding this comment.
Do we want to add the auto update?
There was a problem hiding this comment.
It's on by default, so this should be fine?
CyclingNinja
force-pushed
the
pre_commit_additions
branch
from
25bdad3 to
2c16485
Compare
…e-template into pre_commit_additions
CyclingNinja
force-pushed
the
pre_commit_additions
branch
from
2c16485 to
ba56bd0
Compare
CyclingNinja
force-pushed
the
pre_commit_additions
branch
from
e8905af to
6ae3c5c
Compare
Cadair
reviewed
Mar 8, 2024
Cadair
reviewed
Mar 8, 2024
|
Merged with 3.9 failing as we realised that 3.9 is past it's SPEC 0 expiration date and will be removed soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.