Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate passing numerical keys to NDCollection #778

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Deprecate passing numerical keys to NDCollection #778

merged 1 commit into from
Nov 6, 2024

Conversation

Cadair
Copy link
Member

@Cadair Cadair commented Nov 6, 2024

fixes #736

@Cadair Cadair added this to the 2.3.0 milestone Nov 6, 2024
DanRyanIrish
DanRyanIrish approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@DanRyanIrish DanRyanIrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Approve, pending tests passing

@Cadair Cadair merged commit a7f34b9 into sunpy:main Nov 6, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanRyanIrish DanRyanIrish DanRyanIrish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

NDCollection allows you to set keys as int or float and then gets upset when you slice
2 participants
@Cadair @DanRyanIrish