Rough attempt at ignoring units for rebin #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cadair
reviewed
Jul 8, 2024
nabobalis
commented
Jul 8, 2024
Cadair
reviewed
Jul 9, 2024
nabobalis
commented
Jul 9, 2024
Cadair
approved these changes
Jul 9, 2024
|
@DanRyanIrish do you have philosophical objections to this? |
Co-authored-by: Stuart Mumford <[email protected]>
|
I just spoke to him via carrier pigeon, he said he approves. |
DanRyanIrish
approved these changes
Jul 9, 2024
I'm ok with this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One way to do it.
Context:
sunpy.map.superpixel requireds astropy units as input.
rebin does not enforce this but a lot of superpixel code has units attached, so making that work with those would be a better idea than making users drop the pixel units.