Adding __pow__ to NDCube #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why are user warnings not triggered on tests? |
DanRyanIrish
requested changes
Apr 23, 2024
| new_cube = ndcube_2d_ln_lt_uncert ** power | ||
| check_arithmetic_value_and_units(new_cube, cube_quantity**power) | ||
|
|
||
|
|
There was a problem hiding this comment.
We also need tests for when for the following cases:
self.uncertainty is Noneself.unit is None
These can probably be done in the same test.
Co-authored-by: DanRyanIrish <[email protected]>
Co-authored-by: DanRyanIrish <[email protected]>
Co-authored-by: DanRyanIrish <[email protected]>
Co-authored-by: DanRyanIrish <[email protected]>
nabobalis
reviewed
Apr 23, 2024
DanRyanIrish
requested changes
Apr 23, 2024
DanRyanIrish
approved these changes
Apr 23, 2024
Cadair
reviewed
Apr 23, 2024
ndcube/tests/test_ndcube.py
Outdated
| @@ -1124,6 +1124,30 @@ def test_cube_arithmetic_multiply_notimplementederror(ndcube_2d_ln_lt_units): | |||
| _ = ndcube_2d_ln_lt_units * ndcube_2d_ln_lt_units | |||
|
|
|||
|
|
|||
| @pytest.mark.filterwarnings('ignore::RuntimeWarning') | |||
There was a problem hiding this comment.
Wouldn't it be better to use np.errstate rather than this?
| try: | ||
| new_uncertainty = new_uncertainty.propagate(np.power, self, self.data ** value, correlation=1) | ||
| except ValueError as e: | ||
| if "unsupported operation" in e.args[0]: |
There was a problem hiding this comment.
This is gross, we should open an issue on astropy to raise different error classes for different errors.
Co-authored-by: Stuart Mumford <[email protected]>
Co-authored-by: Stuart Mumford <[email protected]>
shipit.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #575
This add
__pow__to NDCube