Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in optika.materials.snells_law() where an error was raised if diffraction_order was an array. #64

Merged
merged 1 commit into from
Jul 20, 2024

Conversation

byrdie
Copy link
Collaborator

@byrdie byrdie commented Jul 20, 2024

No description provided.

Copy link

codecov bot commented Jul 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.97%. Comparing base (35a41cb) to head (df4917d).
Report is 31 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #64   +/-   ##
=======================================
  Coverage   98.97%   98.97%           
=======================================
  Files          80       80           
  Lines        4198     4198           
=======================================
  Hits         4155     4155           
  Misses         43       43           
Flag Coverage Δ
unittests 98.97% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@byrdie byrdie merged commit 6f4af41 into main Jul 20, 2024
11 checks passed
@byrdie byrdie deleted the bugfix/snells-law-diffraction branch July 20, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant