Modified optika.sensors.charge_collection_efficiency() to not include the effects of loss through the front surface.
#41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byrdie
changed the title
optika.sensors.charge_collection_efficiency() to not inclu…optika.sensors.charge_collection_efficiency() to not include the effects of loss through the front surface.
…de the effects of loss through the front surface.
byrdie
force-pushed
the
bugfix/cce-absorbtivity
branch
from
6819a7e to
65fcddf
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
=======================================
Coverage 98.89% 98.90%
=======================================
Files 78 78
Lines 3892 3913 +21
=======================================
+ Hits 3849 3870 +21
Misses 43 43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…de the effects of loss through the front surface.