Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: version 4.1.0 #2048

Closed
wants to merge 2 commits into from
Closed

docs: version 4.1.0 #2048

wants to merge 2 commits into from

Conversation

nhtyy
Copy link
Collaborator

@nhtyy nhtyy commented Feb 8, 2025

This PR versions the docs for 4.1.0.

Previously we had only maintained "versioned docs", but some commits ended up in the old docs, so this commit reenables "next" docs and unifies the diff between the unmaintained docs and the versioned, thankfully small.

I did this by deleting the unmaintained "next docs", and replacing it with the 4.0.0 docs, then I went through the git diff, and manually unified them.

@nhtyy nhtyy changed the title N/v4.1.0 docs docs: version 4.1.0 Feb 8, 2025
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary?

Copy link
Member

@ratankaliani ratankaliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Gave a pass over the next docs, the 4.1.0 docs should be the exact same.

k256 = { git = "https://github.com/sp1-patches/elliptic-curves", tag = "patch-k256-13.4-sp1-4.1.0" }
```

Note: The curve operations for `k256` are inside of the `ecdsa-core` crate, so you don't need to patch `k256` itself, and just patching `ecdsa-core` is enough.
Copy link

@distractedm1nd distractedm1nd Feb 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is confusing, is it just an artefact from the current version? since there wasn't a k256 patch before

@nhtyy
Copy link
Collaborator Author

nhtyy commented Feb 18, 2025

Closing, as docs are temporally hosted elsewhere.

@nhtyy nhtyy closed this Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants