ci: use global workspace version #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattstam
commented
Jul 15, 2024
| @@ -23,7 +23,7 @@ WORKDIR /sp1/recursion/gnark-cli | |||
|
|
|||
| RUN \ | |||
| --mount=type=cache,target=target \ | |||
| cargo build --release && cp target/release/sp1-recursion-gnark-cli /gnark-cli | |||
| cargo build --release && cp ../../target/release/sp1-recursion-gnark-cli /gnark-cli | |||
There was a problem hiding this comment.
note: this is required for putting recursion/gnark-cli in workspace
jtguibas
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
release-plz bumps each crate
versionindividually based on changes, and I was concerned they would get out of sync with the "global"versionthat we have.The solution is to define a
versionat the workspaceCargo.tomllevel, and have the crates reference thatversion. Also doing this foreditionandlicensesince those are also consistent throughout the workspace (leavingdescriptionandreadmebecause long-term it will have these as different).This will allow new crate releases to always stay in-sync on the same
versiondefined in the workspace Cargo.toml.Also adding
repository,keywords, andcategoriesas this helps with crate.io searchability.