Skip to content

Commit

Permalink
fix: incorrect checks on deferred digest (#1116)
Browse files Browse the repository at this point in the history
  • Loading branch information
jtguibas authored and 0xWOLAND committed Aug 3, 2024
1 parent 36f51ec commit 19a1863
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 8 deletions.
11 changes: 7 additions & 4 deletions recursion/program/src/machine/compress.rs
Original file line number Diff line number Diff line change
Expand Up @@ -479,10 +479,13 @@ where
});
}
builder.if_eq(is_zero, C::N::zero()).then(|builder| {
builder.assert_felt_eq(
deferred_proofs_digest[0],
current_public_values.deferred_proofs_digest[0],
);
#[allow(clippy::needless_range_loop)]
for i in 0..deferred_proofs_digest.len() {
builder.assert_felt_eq(
deferred_proofs_digest[i],
current_public_values.deferred_proofs_digest[i],
);
}
});

// Update the deferred proofs digest.
Expand Down
11 changes: 7 additions & 4 deletions recursion/program/src/machine/core.rs
Original file line number Diff line number Diff line change
Expand Up @@ -508,10 +508,13 @@ where
});
}
builder.if_eq(is_zero, C::N::zero()).then(|builder| {
builder.assert_felt_eq(
deferred_proofs_digest[0],
public_values.deferred_proofs_digest[0],
);
#[allow(clippy::needless_range_loop)]
for i in 0..deferred_proofs_digest.len() {
builder.assert_felt_eq(
deferred_proofs_digest[i],
public_values.deferred_proofs_digest[i],
);
}
});

// If it's not a shard with "CPU", then the deferred proofs digest should not change.
Expand Down

0 comments on commit 19a1863

Please sign in to comment.