Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nits: cleanup ZKL2OutputOracle contract #65

Merged
merged 2 commits into from
Aug 20, 2024
Merged

nits: cleanup ZKL2OutputOracle contract #65

merged 2 commits into from
Aug 20, 2024

Conversation

zobront
Copy link
Collaborator

@zobront zobront commented Aug 19, 2024

No description provided.

ratankaliani
ratankaliani approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@ratankaliani ratankaliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'd add back in a specifier above both structs indicating that they're specific to the zkVM context.

@zobront zobront merged commit ed92a02 into main Aug 20, 2024
1 check passed
@zobront zobront deleted the zach/contract-tweaks branch August 20, 2024 02:27
0xWOLAND pushed a commit that referenced this pull request Aug 27, 2024
@zobront @0xWOLAND
nits: cleanup ZKL2OutputOracle contract (#65)
698bb50 
* zkl2oo contract cleanup

* rm storage header
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ratankaliani ratankaliani ratankaliani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zobront @ratankaliani