Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: load the default extension collection lazily #118

Merged
merged 3 commits into from
Feb 12, 2025

Conversation

scgkiran
Copy link
Contributor

@scgkiran scgkiran commented Feb 12, 2025

This change replaces extensions.DefaultCollection with extensions.GetDefaultCollection()

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 62.50000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 63.77%. Comparing base (3be7ba3) to head (513f32b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
extensions/extension_mgr.go 61.29% 8 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
- Coverage   63.83%   63.77%   -0.07%     
==========================================
  Files          44       44              
  Lines       10893    10904      +11     
==========================================
  Hits         6954     6954              
- Misses       3628     3636       +8     
- Partials      311      314       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@EpsilonPrime EpsilonPrime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up!

Suggestion for alternative PR title:
feat: make the default extension collection load lazily

@scgkiran scgkiran changed the title feat: remove extension package init feat: make the default extension collection load on demand Feb 12, 2025
@scgkiran scgkiran changed the title feat: make the default extension collection load on demand feat: load the default extension collection lazily Feb 12, 2025
Copy link
Member

@EpsilonPrime EpsilonPrime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@scgkiran scgkiran merged commit 261dc94 into substrait-io:main Feb 12, 2025
6 of 8 checks passed
@scgkiran scgkiran deleted the SD-9615 branch February 12, 2025 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants