Aggregate relations do not yet support output mapping changes

[mortbopet]

Unfortunately, my queries seem to hit the Aggregate relations do not yet support output mapping changes error. However, for my given usecase, sufficient information is retained/parsed if i just comment out the following lines:

substrait-cpp/src/substrait/textplan/converter/InitialPlanProtoVisitor.cpp

Lines 632 to 636 in 0376088

	if (!relationData->outputFieldReferences.empty()) {
	errorListener_->addError(
	"Aggregate relations do not yet support output mapping changes.");
	return;
	}

Now that may be bad... but again, works for my usecase. My question is therefore - is there a way to opt-in to this feature, or make the error recoverable, s.t. users (like me) can use upstream substrait-cpp?

[EpsilonPrime]

I put that check in there because it's important to handle (it affects the rest of the plan) but I didn't see any cases where folks were using it (in fact, some systems don't even support emits in aggregations yet). I'll make a stab at adding this missing feature.

[mortbopet]

I put that check in there because it's important to handle (it affects the rest of the plan) but I didn't see any cases where folks were using it (in fact, some systems don't even support emits in aggregations yet). I'll make a stab at adding this missing feature.

Much appreciated! 🙏

[EpsilonPrime]

Progress update: I have binary to text conversion working correctly but there are one or two small bugs in the text to binary parsing that I need to fix. Shouldn't be more than another day.

[EpsilonPrime]

Please let me know if I missed anything.

[mortbopet]

So far looks like the fix is working for my use-case. Thank you very much for looking into this!