Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix starknet transaction fields types #22

Merged
merged 2 commits into from
Feb 26, 2025
Merged

Fix starknet transaction fields types #22

merged 2 commits into from
Feb 26, 2025

Conversation

stwiname
Copy link
Contributor

Description

  • Fixes transaction hash being undefined
  • Fix nonce and maxFee type and optionality
  • Improve typescript types

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have tested locally
  • I have performed a self review of my changes
  • Updated any relevant documentation
  • Linked to any relevant issues
  • I have added tests relevant to my changes
  • Any dependent changes have been merged and published in downstream modules
  • My code is up to date with the base branch
  • I have updated relevant changelogs. We suggest using chan

Copy link

github-actions bot commented Feb 24, 2025

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements 48.39% 2294/4741
🟡 Branches 66.85% 238/356
🔴 Functions 52.48% 106/202
🔴 Lines 48.39% 2294/4741

Test suite run success

47 tests passing in 11 suites.

Report generated by 🧪jest coverage report action from 86d3cb6

@stwiname stwiname merged commit 101143a into main Feb 26, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants