-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Header
not found timestamp
field
#366
Conversation
Coverage reportCaution Test run failed
Test suite run failedFailed tests: 5/96. Failed suites: 3/14.
Report generated by 🧪jest coverage report action from d0dfd06 |
packages/node/CHANGELOG.md
Outdated
@@ -5,6 +5,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | |||
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | |||
|
|||
## [Unreleased] | |||
|
|||
### Fixed | |||
- Fix `Header` not found `timestamp` field |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Fix `Header` not found `timestamp` field | |
- `timestamp` field missing on `Header` |
@@ -22,6 +22,7 @@ const makeHeader = (height: number, finalized?: boolean): Header => ({ | |||
blockHeight: height, | |||
blockHash: hexify(`0xABC${height}${finalized ? 'f' : ''}`), | |||
parentHash: hexify(`0xABC${height - 1}${finalized ? 'f' : ''}`), | |||
timestamp: new Date((1740100000 + height) * 1000), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where does 1740100000
come from? Can we move it to a constant with a description
Description
When using historical: timestamp, because getHeader does not return the timestamp, it causes the crawl to not function properly.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Checklist