Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix query params being stripped #301

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Fix query params being stripped #301

merged 2 commits into from
Jun 7, 2024

Conversation

stwiname
Copy link

@stwiname stwiname commented Jun 6, 2024

Description

In order to support api keys in headers we convert query params to headers, this stripped the query params, there was no need to strip the query params, this keeps the query params as provided in the config

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have tested locally
  • I have performed a self review of my changes
  • Updated any relevant documentation
  • Linked to any relevant issues
  • I have added tests relevant to my changes
  • Any dependent changes have been merged and published in downstream modules
  • My code is up to date with the base branch
  • I have updated relevant changelogs. We suggest using chan

Copy link

github-actions bot commented Jun 6, 2024

Coverage report

Caution

Test run failed

St.
Category Percentage Covered / Total
🔴 Statements 49.58% 3189/6432
🟡 Branches 68.35% 378/553
🔴 Functions 49.12% 140/285
🔴 Lines 49.58% 3189/6432

Test suite run failed

Failed tests: 1/86. Failed suites: 1/14.
  ● rawBlockToEthBlock › can fetch receipts

    expect(received).resolves.not.toThrow()

    Received promise rejected instead of resolved
    Rejected to value: [TypeError: Cannot read properties of null (reading 'from')]

      110 |     const block = rawBlockToEthBlock(raw, api);
      111 |
    > 112 |     await expect(block.block.transactions[0].receipt()).resolves.not.toThrow();
          |           ^
      113 |   });
      114 | });
      115 |

      at expect (node_modules/expect/build/index.js:105:15)
      at Object.<anonymous> (packages/node/src/indexer/dictionary/v2/utils.spec.ts:112:11)

Report generated by 🧪jest coverage report action from bcd2b5d

@stwiname stwiname merged commit b57630e into main Jun 7, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants