Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dictionary V2 Ethereum #225
Dictionary V2 Ethereum #225
Changes from 41 commits
e348509
bda0b32
846ba4f
88d92c2
038e1c9
17c1630
728ed61
0b4cc19
e4f1c8f
47e64e5
72168b9
55ee39a
2a51107
9e62536
f45529b
37f04cf
2c8e564
8d1efcb
370c537
b67e2a6
5d0e44c
1d5b631
a8b7a4b
f858c10
a65f951
eddc760
8e90675
7757340
b04df53
df186af
c7ee51e
4151e83
5fa4c83
4703a9c
2d5dd39
9400555
c6067ca
3299f75
09aefcb
4254f60
48184c1
d4fe14e
f72e39f
b3cb703
01cfd7d
e031b3f
c0442b7
acf53f5
0e73132
5fba295
8d1e95f
73b2bb9
b1c32ca
ae8ad1d
0939862
2ff323d
d934910
1943764
09973bd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have tests for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be saved for another PR. But this service has nothing specific to ethereum, it would be good if this could now live purely in node-core. I think only substrate would need a specific version because of specVersions