Added info about using merged-kubeconfig for joining the cluster. #209

aswinsuryan · 2020-02-26T13:22:42Z

Signed-off-by: Aswin Surayanarayanan [email protected]

Fixes: #210

submariner-bot · 2020-02-26T13:22:51Z

🤖 Created branch: z_pr209/aswinsuryan/create-kubeconfig

skitt · 2020-02-26T13:41:29Z

README.md

 * Deploy Broker with Dataplane - To deploy the Submariner broker along with the data cluster, run using the broker-info.subm generated in the folder from which the previous step was run.
 ```
-subctl deploy-broker --kubeconfig <PATH-TO-KUBECONFIG-BROKER> --dataplane --service-discovery --broker-cluster-context <BROKER-CONTEXT-NAME> --clusterid  <CLUSTER-ID-FOR-TUNNELS>
+subctl deploy-broker --kubecontext <BROKER-CONTEXT-NAME>  --kubeconfig <PATH-TO-KUBECONFIG-BROKER> --dataplane --service-discovery --broker-cluster-context <BROKER-CONTEXT-NAME> --clusterid  <CLUSTER-ID-FOR-TUNNELS>


Does this step require a non-merged configuration?

Yes, else it is failing.

README.md

vthapar · 2020-02-27T06:21:42Z

README.md

 * Deploy Broker with Dataplane - To deploy the Submariner broker along with the data cluster, run using the broker-info.subm generated in the folder from which the previous step was run.
 ```
-subctl deploy-broker --kubeconfig <PATH-TO-KUBECONFIG-BROKER> --dataplane --service-discovery --broker-cluster-context <BROKER-CONTEXT-NAME> --clusterid  <CLUSTER-ID-FOR-TUNNELS>
+subctl deploy-broker --kubecontext <BROKER-CONTEXT-NAME>  --kubeconfig <PATH-TO-KUBECONFIG-BROKER> --dataplane --service-discovery --broker-cluster-context <BROKER-CONTEXT-NAME> --clusterid  <CLUSTER-ID-FOR-TUNNELS>


Add a warning to highlight that due to a bug deploy-broker requires unmerged kubeconfg and should use workaround of using unmerged config.

⚠️ Due to a bug deploy-broker fails if using merged kubeconfig. Use unmerged broker kubeconfig as a workaround while issue is being fixed.

Add link to issue.

I think since it is due to Kubefed and removal of kubefed will fix this, it would be ok right if we don't mention an explicit warning. May be general warning in the initial section should be fine.

submariner-bot · 2020-03-02T09:58:34Z

🤖 Updated branch: z_pr209/aswinsuryan/create-kubeconfig

skitt · 2020-03-03T09:07:55Z

This will also need to be cherry-picked to the 0.1 branch.

manosnoam · 2020-03-03T09:21:54Z

README.md

@@ -66,15 +66,20 @@ The [Lighthouse](https://github.com/submariner-io/lighthouse) project helps in c

 To deploy Submariner with Lighthouse follow the below steps.

+* Create a kubeconfig file which has the context of all the clusters. If KUBECONFIG environment variable set with the path to all clusters, you could use the below command.
+```
+kubectl config view --flatten > kubeconfig_merged


After creating "kubeconfig_merged", where should it be used ?
Please specify command.

I have added the details in the join command, where this should be used.

I have added more details on the README based on your feedback.

manosnoam · 2020-03-03T09:24:34Z

README.md

 * Deploy Broker with Dataplane - To deploy the Submariner broker along with the data cluster, run using the broker-info.subm generated in the folder from which the previous step was run.
 ```
-subctl deploy-broker --kubeconfig <PATH-TO-KUBECONFIG-BROKER> --dataplane --service-discovery --broker-cluster-context <BROKER-CONTEXT-NAME> --clusterid  <CLUSTER-ID-FOR-TUNNELS>
+subctl deploy-broker --kubecontext <BROKER-CONTEXT-NAME>  --kubeconfig <PATH-TO-KUBECONFIG-BROKER> --dataplane --service-discovery --broker-cluster-context <BROKER-CONTEXT-NAME> --clusterid  <CLUSTER-ID-FOR-TUNNELS>


Before calling deploy command, what if the current kubeconfig (already exported) is pointing to one of the clusters, which is not the broker cluster ?

--kubecontext overides the current-cluster selection.

submariner-bot · 2020-03-03T10:30:33Z

🤖 Updated branch: z_pr209/aswinsuryan/create-kubeconfig

README.md

submariner-bot · 2020-03-03T11:31:47Z

🤖 Updated branch: z_pr209/aswinsuryan/create-kubeconfig

submariner-bot · 2020-03-03T13:11:07Z

🤖 Updated branch: z_pr209/aswinsuryan/create-kubeconfig

README.md

mangelajo

This does not work for openshift configs, we need a solution for that before we call this closed.

README.md

mangelajo · 2020-03-04T08:57:45Z

README.md

 ```
-subctl deploy-broker --kubeconfig <PATH-TO-KUBECONFIG-BROKER> --dataplane --service-discovery --broker-cluster-context <BROKER-CONTEXT-NAME> --clusterid  <CLUSTER-ID-FOR-TUNNELS>
+kubectl config view --flatten > merged_kubeconfig


But this does not work for openshift configs, all clusters will have context "admin".

We need a solution for that as part of #210

mangelajo · 2020-03-04T09:01:45Z

@aswinsuryan @skitt @vthapar see this for reference: https://www.youtube.com/watch?v=zuh3JFtNbeU

Probabably we can include that step as part of an openshift with discovery quickstart

Signed-off-by: Aswin Surayanarayanan <[email protected]>

submariner-bot · 2020-03-05T09:48:15Z

🤖 Updated branch: z_pr209/aswinsuryan/create-kubeconfig

mangelajo · 2020-03-05T09:56:35Z

README.md

+kubectl config view --flatten > merged_kubeconfig
+```
+
+Note, if you are using Openshift configs and if it has the default name for users (admin), merging the files will create a conflict. So you can change the name to a meaningful name before running the above command using,


mangelajo · 2020-03-05T10:12:44Z

This will also need to be cherry-picked to the 0.1 branch.

Technically I think we don't need to do that since we are not publishing separate docs. I think we may want to move all this to the website instead when we are comfortable about it.

submariner-bot · 2020-03-05T10:13:25Z

🤖 Updated branch: z_pr209/aswinsuryan/create-kubeconfig

submariner-bot · 2020-03-05T10:13:34Z

🤖 Closed branches: [z_pr209/aswinsuryan/create-kubeconfig]

skitt · 2020-03-05T10:48:23Z

This will also need to be cherry-picked to the 0.1 branch.

Technically I think we don't need to do that since we are not publishing separate docs. I think we may want to move all this to the website instead when we are comfortable about it.

Even if we don’t publish branched docs anywhere, it’s nice to provide the most relevant docs in the source tarballs from the releases page ;-).

skitt · 2020-03-05T10:50:05Z

Cherry-picked in #233.

aswinsuryan requested review from mangelajo, skitt and vthapar February 26, 2020 13:22

skitt mentioned this pull request Feb 26, 2020

Document the use of merged kubeconfigs #210

Closed

skitt reviewed Feb 26, 2020

View reviewed changes

vthapar requested changes Feb 27, 2020

View reviewed changes

aswinsuryan mentioned this pull request Mar 2, 2020

SubCtl with --service-discovery failed to join a clusterID, since kubefedctl gets wrong subdomain #194

Closed

aswinsuryan force-pushed the create-kubeconfig branch from 0487610 to 1b77c58 Compare March 2, 2020 09:58

skitt added this to the v0.1.1 milestone Mar 3, 2020

manosnoam requested changes Mar 3, 2020

View reviewed changes

aswinsuryan force-pushed the create-kubeconfig branch from 1b77c58 to 3e9ecf1 Compare March 3, 2020 10:30

manosnoam approved these changes Mar 3, 2020

View reviewed changes

README.md Outdated Show resolved Hide resolved

aswinsuryan force-pushed the create-kubeconfig branch from 3e9ecf1 to 2bea6e4 Compare March 3, 2020 11:31

aswinsuryan force-pushed the create-kubeconfig branch from 2bea6e4 to 820d5eb Compare March 3, 2020 13:10

manosnoam reviewed Mar 3, 2020

View reviewed changes

README.md Outdated Show resolved Hide resolved

mangelajo reviewed Mar 4, 2020

View reviewed changes

Added info about using merged-kubeconfig for joining the cluster.

d4a3c28

Signed-off-by: Aswin Surayanarayanan <[email protected]>

aswinsuryan force-pushed the create-kubeconfig branch from 820d5eb to d4a3c28 Compare March 5, 2020 09:48

mangelajo reviewed Mar 5, 2020

View reviewed changes

mangelajo approved these changes Mar 5, 2020

View reviewed changes

vthapar approved these changes Mar 5, 2020

View reviewed changes

Merge branch 'master' into create-kubeconfig

2b31c3c

mangelajo merged commit cf580e1 into submariner-io:master Mar 5, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added info about using merged-kubeconfig for joining the cluster. #209

Added info about using merged-kubeconfig for joining the cluster. #209

aswinsuryan commented Feb 26, 2020 •

edited by mangelajo

Loading

submariner-bot commented Feb 26, 2020

skitt Feb 26, 2020

aswinsuryan Feb 27, 2020

vthapar Feb 27, 2020

aswinsuryan Mar 2, 2020

submariner-bot commented Mar 2, 2020

skitt commented Mar 3, 2020

manosnoam Mar 3, 2020

aswinsuryan Mar 3, 2020

aswinsuryan Mar 3, 2020

manosnoam Mar 3, 2020

aswinsuryan Mar 3, 2020

submariner-bot commented Mar 3, 2020

submariner-bot commented Mar 3, 2020

submariner-bot commented Mar 3, 2020

mangelajo left a comment

mangelajo Mar 4, 2020

mangelajo commented Mar 4, 2020

submariner-bot commented Mar 5, 2020

mangelajo Mar 5, 2020

mangelajo commented Mar 5, 2020

submariner-bot commented Mar 5, 2020

submariner-bot commented Mar 5, 2020

skitt commented Mar 5, 2020

skitt commented Mar 5, 2020

Added info about using merged-kubeconfig for joining the cluster. #209

Added info about using merged-kubeconfig for joining the cluster. #209

Conversation

aswinsuryan commented Feb 26, 2020 • edited by mangelajo Loading

submariner-bot commented Feb 26, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

submariner-bot commented Mar 2, 2020

skitt commented Mar 3, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

submariner-bot commented Mar 3, 2020

submariner-bot commented Mar 3, 2020

submariner-bot commented Mar 3, 2020

mangelajo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mangelajo commented Mar 4, 2020

submariner-bot commented Mar 5, 2020

Choose a reason for hiding this comment

mangelajo commented Mar 5, 2020

submariner-bot commented Mar 5, 2020

submariner-bot commented Mar 5, 2020

skitt commented Mar 5, 2020

skitt commented Mar 5, 2020

aswinsuryan commented Feb 26, 2020 •

edited by mangelajo

Loading