Fix flaky verify failures with headless+globalnet #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Created branch: z_pr272/vthapar/e2e-verify-fix |
mangelajo
reviewed
Aug 28, 2020
mangelajo
reviewed
Aug 28, 2020
mangelajo
reviewed
Aug 28, 2020
When running `subctl verify`, TestContext.GlobalnetEnabled flag is not set by the time we check for it. Move the flag check to inside `It()` block to make sure it is always set by the time we run our tests. Signed-off-by: Vishal Thapar <[email protected]>
vthapar
force-pushed
the
e2e-verify-fix
branch
from
4fb9749 to
e34f04e
Compare
|
🤖 Updated branch: z_pr272/vthapar/e2e-verify-fix |
tpantelis
approved these changes
Aug 28, 2020
mangelajo
approved these changes
Aug 31, 2020
|
🤖 Closed branches: [z_pr272/vthapar/e2e-verify-fix] |
skitt
pushed a commit
to submariner-io/submariner-operator
that referenced
this pull request
Sep 1, 2020
No functional changes exist in this release, but fixes the testing issue of Lighthouse + Globalnet handled in [1] [1] submariner-io/lighthouse#272 Signed-off-by: Miguel Angel Ajo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
subctl verify, TestContext.GlobalnetEnabled flag is not set by thetime we check for it. Move the flag check to inside
It()block to makesure it is always set by the time we run our tests.
Signed-off-by: Vishal Thapar [email protected]