Completion filtering fixes #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pressing <tab> in documents results in huge "LSP: No match for inserted "<entire document>.." entries in the console.
…ng ahead. If typing view.settings, completion at dot is cancelled by "s", "e" etc. even though original request is still relevant
If typing view.settings() quickly, a popup would show at the cursor offering "settings()". In the response handler, we detect if cursor has passed a word boundary and ignore the result if so.
If there are no completion results, typing view.s would trigger requests at both '.' and 's'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing with python language server, starting with
and typing
.settings()quickly, resulted in several completion requests, and the results shown when irrelevant:This sequence should result in only 1 completion request of which the results are never shown.
This PR
is_same_completion(173ea35)is_same_completionreturn True when going from.to.sby undoing the fix for Inconsistent autocomplete behavior #745 (861b7e5)Also fixes a related issue where pressing tab would dump a huge chunk of document in the console from the inadvertently triggered
on_completion_insertedlogic viainsert_best_completion(d06e6cd)