-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ruby] Add lambda operator to the list of builtin functions #2411
Conversation
I assume
I think the scope name used in D is the most appropriate here and up to date with the scope naming guidelines. |
Thanks for your feedback, I just changed the scope to match D, however, I'm not sure why tests failed (seems unrelated to this) or is there anything else I need to do regarding adding this lambda operator? |
I think the tests are not your fault. See #2328 |
Yeah, I'm working on getting the CI test runner fixed |
If you rebase on master, the CI should be working now. |
e2037af
to
833f18e
Compare
Awesome, just rebased and it's passing now. Thanks! |
Ruby/syntax_test_ruby.rb
Outdated
@@ -1128,6 +1128,8 @@ class MyClass | |||
exit! 2 | |||
#^^^^ support.function.builtin | |||
|
|||
-> | |||
#^^ meta.function.ruby storage.type.function.ruby keyword.declaration.function.lambda.ruby |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good first step, but perhaps provide a slightly more detailed example also? I'd recommend perhaps some parameters and a simple function body.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, I've pushed a better example for the ->
Thanks! |
This is mostly to fix the ligature issue, since
->
is currently tokenizing as arithmetic and comparisionBefore:


After (ligature works):
