[JavaScript] Improved identifier and number lexing. #1427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ruby may need this sort of thing, too. |
sharkdp
reviewed
Apr 30, 2018
| identifier: '{{identifier_start}}{{identifier_part}}*{{identifier_break}}' | ||
| constant_identifier: '[[:upper:]]{{identifier_part}}*{{identifier_break}}' | ||
| dollar_only_identifier: '\${{identifier_break}}' | ||
| dollar_identifier: '(\$){{identifier_part}}*{{identifier_break}}+' |
There was a problem hiding this comment.
There was a problem hiding this comment.
It's valid but redundant. I don't know why syntect doesn't handle this, but if you open up a PR to remove the + I'll endorse it.
deathaxe
pushed a commit
to deathaxe/sublime-packages
that referenced
this pull request
Jun 9, 2019
…tifiers [JavaScript] Improved identifier and number lexing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the identifier rules from the spec.
The syntax previously used
\bin a lot of rules. This is not quite right, and it leads to some bugs:function$NotAFunctionWhere
\bfollowed identifier characters, I replaced it with a negative lookahead. (Testing showed that there was no effect on performance.) Where\bpreceded identifier characters, we would need a lookbehind, which the fast regexp engine does not support. However, we don't actually need assertions at the beginning of matches if we maintain the invariant that the "cursor" should never pause with identifier characters on both sides. This is guaranteed if every match that ends with an identifier character ends with the negative lookahead.Implementing this correctly required changing the implementation of numeric literals. I added more tests and improved the behavior of numbers in some corner cases.