Autogen update: totp and recovery codes #185
Conversation
stytch/consumer/models/sessions.py
Outdated
|
|
||
| class WebAuthnFactor(pydantic.BaseModel): | ||
| webauthn_registration_id: str | ||
| domain: str | ||
| user_agent: Optional[str] = None | ||
| # ENDMANUAL(WebAuthnFactor) | ||
| user_agent: str |
There was a problem hiding this comment.
This was already defined above, so now there are two. Either it shouldn't be manual (if it's already defined in the proto defs) or you just need to rerun once more so that it gets deduped
There was a problem hiding this comment.
Yeah the manual was removed in another PR and is fixed now when I merged main
There was a problem hiding this comment.
This was done due to this ticket: https://linear.app/stytch/issue/OBACK-63/[python-sdk]-webauthn-factor-user-agent-field-required-error. We're ok rolling this back?
There was a problem hiding this comment.
Good catch. This would not be okay to roll back. Instead we need to mark this as an explicitly optional field in the protos, cc @taronish-stytch
There was a problem hiding this comment.
There was a problem hiding this comment.
I'm going to approve to unblock, but take care to make the change to have that field be optional so it doesn't reintroduce the bug that @ollie-stytch linked.
stytch/consumer/models/sessions.py
Outdated
|
|
||
| class WebAuthnFactor(pydantic.BaseModel): | ||
| webauthn_registration_id: str | ||
| domain: str | ||
| user_agent: Optional[str] = None | ||
| # ENDMANUAL(WebAuthnFactor) | ||
| user_agent: str |
There was a problem hiding this comment.
Good catch. This would not be okay to roll back. Instead we need to mark this as an explicitly optional field in the protos, cc @taronish-stytch
No description provided.