Run auto-gen before committing M2M manual changes #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-stytch
reviewed
Aug 9, 2023
| @@ -173,12 +173,12 @@ async def delete_async( | |||
| res = await self.async_client.delete(url) | |||
| return DeleteResponse.from_json(res.response.status, res.json) | |||
|
|
|||
| def delete_phone_number( | |||
| def delete_mfa_phone_number( | |||
There was a problem hiding this comment.
Were the old MFA methods published already? Is this a breaking change? (Probably a question for the MFA team)
There was a problem hiding this comment.
We made these changes last week (pre-launch) but they were only propagated to the Node repo, so I would say this isn't a breaking change
max-stytch
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR runs the SDK autogenerator on the branch. A subsequent PR will add M2M manual methods.