added support for display: xxx !important, display: box !important included #72
Conversation
|
yeah I agree, some more list operation stuff would be great for stylus. |
|
i'll merge until we can come up with something else |
| display: vendor-value(type) | ||
| display(type, args...) | ||
| if type == box | ||
| display: vendor-value(type, args) |
There was a problem hiding this comment.
i think we could do display: vendor-value(type) args as well and bypass manipulating vendor-value(), it should work fine
There was a problem hiding this comment.
you mean so that vendor.styl value wouldn't need to be changed at all? i dont think i'm quite understanding. the way i'm seeing it, if vendor-value doesn't have the (arg, args...) then the !important won't get applied to vendorized values, eg:
[hidden] {
display: -webkit-box;
display: -moz-box;
display: -o-box;
display: -ms-box;
display: box !important;
}
There was a problem hiding this comment.
oh right sorry, nevermind me I'm in limbo
|
hey TJ, could you merge this please? |
|
@visionmedia We stumbled upon this bug, this can be somewhat critical, 'cause Could you merge it? What are the stoppers for it? I could provide tests for this PR, or after merge for all |
|
hmm wont apply anymore, no stoppers that I remember, I just dont remember them until it pops up in notifications |
|
I just spent 20 minutes trying to figure out what's wrong, because |
there might have been a more elegant solution, but the one I thought of needed
pop()support to extract things from arguments.would be a nice addition to the built-ins.
also, ideally this vendor-value would cover situations like
transition: ***transform*** 1.5s, opacity .5s, but it gets really complicated because you can't count ontransformbeingarguments[0]so...maybe the vendor value function could just take the name of the value you want to vendorize and then apply it wherever it occurred in the callees arguments. not sure.
anyways.