Typescript error (3.4.3)

[ivanov-v]

• polished version: 3.4.3
• JSS-in_CSS library and version: styled-components 5.0
• Any relevant JS library and version: 16.12.0

Mixin/Helper/Shorthand you were using and how you were using it:

export const NativeInput = styled.input<{
  variant: InputVariant;
  hasAdornment: boolean;
}>`
  ${ellipsis()};
`;

What you are seeing:
Type 'Styles' is not assignable to type 'string'.

What you expected to see:

Types must match

[leocavalcante]

+1 here. Just updated my deps and grabbed 3.4.3, now a previously working code shouts:

27:5 Argument of type 'Styles' is not assignable to parameter of type 'Interpolation<ThemeProps<DefaultTheme>>'.
  Type 'Styles' is not assignable to type 'string'.
    25 | 
    26 | const GlobalStyle = createGlobalStyle`
  > 27 |   ${din}
       |     ^
    28 |   ${dinBold}
    29 |   ${dinCondensed}
    30 |   ${dinCondensedBold}

The code uses fontFace + createGlobalStyle

import {createGlobalStyle} from "styled-components";
import {fontFace} from "polished";

const din = fontFace({
  fontFamily: 'Din',
  fontFilePath: '/assets/fonts/d-din-webfont',
});

const dinBold = fontFace({
  fontFamily: 'Din',
  fontFilePath: '/assets/fonts/d-din-bold-webfont',
  fontWeight: 'bold',
});

const dinCondensed = fontFace({
  fontFamily: 'Din Condensed',
  fontFilePath: '/assets/fonts/d-dincondensed-webfont',
});

const dinCondensedBold = fontFace({
  fontFamily: 'Din Condensed',
  fontFilePath: '/assets/fonts/d-dincondensed-bold-webfont',
  fontWeight: 'bold',
});

const GlobalStyle = createGlobalStyle`
  ${din}
  ${dinBold}
  ${dinCondensed}
  ${dinCondensedBold}

  body {
    margin: 0;
    background-color: #383838;
    color: white;
  }
`;

export default GlobalStyle;

[ivanov-v]

Maybe this line breaks?

[bhough]

🎉 This issue has been resolved in version 3.4.4 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[bhough]

@ivanov-v @leocavalcante Apologies, our TS test harness didn't catch this for some reason. v3.4.4 should address this, but we will await confirmation before closing.

[ivanov-v]

@ivanov-v @leocavalcante Apologies, our TS test harness didn't catch this for some reason. v3.4.4 should address this, but we will await confirmation before closing.

Now work without errors

[leocavalcante]

@ivanov-v @leocavalcante Apologies, our TS test harness didn't catch this for some reason. v3.4.4 should address this, but we will await confirmation before closing.

Thank you very much for the prompt fix.