Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove isLarge attribute from buttons for WP 5.5 #17

Merged
merged 1 commit into from
Aug 7, 2020

Conversation

nickcernis
Copy link
Contributor

Prevents the “React does not recognize the isLarge prop on a DOM element” console warning in WP 5.5 caused by the isLarge attribute being removed in 5.5.

Screenshot 2020-08-07 at 16 59 35

Testing instructions

Under WP 5.5:

  1. Create a custom block containing an image field.
  2. Add the custom block to a page.
  3. Click the block to edit its fields. There should be no console warnings (used to be present due to the “Upload” and “Media Library” buttons).
  4. Add an image and dismiss the image popover to return to the editor.
  5. There should be no warning in the console (from the “Remove” button).

See

Prevents a console error in WP 5.5 caused by the attribute
being removed in 5.5.

See:
- Removal: WordPress/gutenberg#23239
- Note about isLarge having no effect in the first place: WordPress/gutenberg#16541 (comment)
@nickcernis nickcernis requested a review from kienstra August 7, 2020 15:00
@mindctrl
Copy link
Contributor

mindctrl commented Aug 7, 2020

Good catch. We saw yesterday in GB and are removing it too.

@kienstra
Copy link
Contributor

kienstra commented Aug 7, 2020

@nickcernis,
Thanks a lot for opening this! I'll probably merge it soon.

Copy link
Contributor

@kienstra kienstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nickcernis,
Thanks a lot for fixing this. The button still looks good, and there's no console warning:

button-slitsdf

@kienstra kienstra merged commit a178b51 into develop Aug 7, 2020
@kienstra kienstra deleted the remove-is-large branch August 7, 2020 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants