fix!: changed to simply move to cfgs field and add opt_cfgs method to Cmd #27

sttk · 2024-07-23T15:59:46Z

Because it's unnecessary to use std::mem::replace for setting cfgs field of Cmd, and a public field can be overridden.

src/lib.rs

src/parse/parse_for.rs

… Cmd (#27)

sttk added 2 commits July 24, 2024 00:56

fix: changed to simply move to cfgs field and add opt_cfgs method to Cmd

99552dc

fix:(review) modified what pointed out

b8d29b1

sttk commented Jul 23, 2024

View reviewed changes

src/lib.rs Outdated Show resolved Hide resolved

src/parse/parse_for.rs Outdated Show resolved Hide resolved

sttk merged commit 0f54c42 into main Jul 23, 2024
7 checks passed

sttk deleted the simply-move-to-cfgs-of-cmd branch July 23, 2024 16:12

sttk added a commit that referenced this pull request Jul 23, 2024

fix!: changed to simply move to cfgs field and add opt_cfgs method to…

d01cd09

… Cmd (#27)

sttk changed the title ~~fix: changed to simply move to cfgs field and add opt_cfgs method to Cmd~~ fix!: changed to simply move to cfgs field and add opt_cfgs method to Cmd Jul 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix!: changed to simply move to cfgs field and add opt_cfgs method to Cmd #27

fix!: changed to simply move to cfgs field and add opt_cfgs method to Cmd #27

sttk commented Jul 23, 2024

fix!: changed to simply move to cfgs field and add opt_cfgs method to Cmd #27

fix!: changed to simply move to cfgs field and add opt_cfgs method to Cmd #27

Conversation

sttk commented Jul 23, 2024