Continue middleware chain after download. #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@loay, @raymondfeng: please review. |
| @@ -258,6 +258,9 @@ exports.download = function(provider, req, res, container, file, cb) { | |||
| reader.on('error', function(err) { | |||
| handleError(res, err); | |||
| }); | |||
| reader.on('end', function() { | |||
There was a problem hiding this comment.
Does the same listener apply to line 247 too?
richardpringle
force-pushed
the
fix/#59
branch
from
155f816 to
20d9aaa
Compare
|
While this may be a good short-term fix, we should strongly consider rewriting the method to use the new strong-remoting type "file" instead. That will also fix the swagger description of the See strongloop/loopback#2063 (comment) and strongloop/strong-remoting#284 for more details. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connect to #59