feat: forbid nullable codebuild variables, to use default variables on null #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marcel2603
requested review from
moritzzimmer,
thisismana and
saefty
as code owners
Marcel2603
changed the title
Marcel2603
changed the title
Marcel2603
changed the title
moritzzimmer
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, you can use "null" for the value of the codebuild-variables. If you do that, you will receive an error from the underlying module.
In order to fix this, I've set the variables to
nullable=falsewhich should protect you from this error.If you paste null, then the default value will be used (source: https://developer.hashicorp.com/terraform/language/values/variables#disallowing-null-input-values)