Relax constraints on objects that we'll accept as a file #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When uploading a file, we previously made a check on whether it supported both `#read` and `#path` before wrapping it in a `Faraday::UploadIO` and sending it off. The second check on `#path` isn't strictly necessary, and as reported in #761 can prevent objects created by `open-uri` from being compatible with file upload. Here we remove the check `#path` so that we just require that objects support `#read`, and in addition error when an object is passed that's not file-compatible and not a string. This should prevent users from seeing the very confusing "Invalid hash" error in these situations. Fixes #761.
brandur-stripe
force-pushed
the
brandur-relax-file-constraints
branch
from
b761820 to
81b7cb3
Compare
|
Thanks OB! Taking this out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When uploading a file, we previously made a check on whether it
supported both
#readand#pathbefore wrapping it in aFaraday::UploadIOand sending it off. The second check on#pathisn't strictly necessary, and as reported in #761 can prevent objects
created by
open-urifrom being compatible with file upload.Here we remove the check
#pathso that we just require that objectssupport
#read, and in addition error when an object is passed that'snot file-compatible and not a string. This should prevent users from
seeing the very confusing "Invalid hash" error in these situations.
Fixes #761.
r? @ob-stripe
cc @stripe/api-libraries