Remove attempt to nicen UploadIO in logs
#743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #741 I tried to do something too clever by replacing instances of `Faraday::UploadIO` found in parameters with a human-readable string to improve `STRIPE_LOG` logging output. I thought I'd tested it at the time, but apparently not (or not well enough), and this change caused the regression detailed in #742. My findings about how Faraday encodes multipart were apparently wrong and it does use these parameters, so here we remove the step where we try to nicen them for logging. The logs look a little worse, but it's not that big of a deal. I've tested this patch against the API and confirmed that it addresses the problem. Fixes #742.
|
Thanks for the quick review turnaround Olivier! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #741 I tried to do something too clever by replacing instances of
Faraday::UploadIOfound in parameters with a human-readable string toimprove
STRIPE_LOGlogging output.I thought I'd tested it at the time, but apparently not (or not well
enough), and this change caused the regression detailed in #742.
My findings about how Faraday encodes multipart were apparently wrong
and it does use these parameters, so here we remove the step where we
try to nicen them for logging. The logs look a little worse, but it's
not that big of a deal.
I've tested this patch against the API and confirmed that it addresses
the problem.
Fixes #742.
r? @ob-stripe