Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ability to perform edit-actions on bitcoin receivers #675

Merged

Conversation

tomer-stripe
Copy link
Contributor

@tomer-stripe tomer-stripe commented Aug 16, 2018

Tests pass:

» bundle exec rake test
[Coveralls] Set up the SimpleCov formatter.
[Coveralls] Using SimpleCov's 'test_frameworks' settings.
/Users/tomer/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/shoulda-context-1.2.2/lib/shoulda/context/context.rb:400: warning: assigned but unused variable - context
Loaded suite /Users/tomer/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/rake-12.3.1/lib/rake/rake_test_loader
Started
..........................................................................................................................................
..........................................................................................................................................
..........................................................................................................................................
...............................................................
Finished in 2.654357 seconds.
------------------------------------------------------------------------------------------------------------------------------------------
477 tests, 571 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
------------------------------------------------------------------------------------------------------------------------------------------
179.70 tests/s, 215.12 assertions/s

Looks like these didn't have much coverage :(

@brandur-stripe
Copy link
Contributor

LGTM.

@tomer-stripe Do you want to try to cut the release? There's instructions in our docs and you can use my changelog message from stripe-python for inspiration.

@tomer-stripe
Copy link
Contributor Author

Yep! I can give that a shot

@tomer-stripe tomer-stripe merged commit 0d7315f into master Aug 27, 2018
@tomer-stripe tomer-stripe deleted the tomer-remove-edittable-bitcoin-receivers-actions branch August 27, 2018 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants