Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generated code #1419

Merged
merged 5 commits into from
Jun 24, 2024
Merged

Update generated code #1419

merged 5 commits into from
Jun 24, 2024

Conversation

stripe-openapi[bot]
Copy link
Contributor

@stripe-openapi stripe-openapi bot commented Jun 18, 2024

Codegen for openapi v1093.

Changelog

This release changes the pinned API version to 2024-06-20. Please read the API Upgrade Guide and carefully review the API changes before upgrading.

Additions

  • Add support for finalize_amount test helper method on resource Issuing.Authorization

@stripe-openapi stripe-openapi bot enabled auto-merge (squash) June 18, 2024 19:42
@stripe-openapi stripe-openapi bot merged commit a0542ff into master Jun 24, 2024
12 checks passed
@stripe-openapi stripe-openapi bot deleted the latest-codegen-master branch June 24, 2024 22:49
@WillRogers727
Copy link

@ramya-stripe I can see a breaking change in the description here, but the code doesn't appear to reflect that change. Has the change been pushed elsewhere or was the description included unintentionally?

@ramya-stripe
Copy link
Contributor

Ah, that was my mistake
That breaking change was part of another PR

https://github.com/stripe/stripe-ruby/blob/master/CHANGELOG.md#1200---2024-06-24 has the complete changelog

@fschwahn
Copy link

@ramya-stripe I'm having a hard time understanding the breaking change in v12 of the gem. Looking at https://my.diffend.io/gems/stripe/11.7.0/12.0.0 there don't seem to be any changes to the retrieve-method at all. Can you shed some light what we should be looking out for?

@ramya-stripe
Copy link
Contributor

@fschwahn You are right. Looks like we missed merging those changes to master branch. We were referring to #1423

So, the only breaking change left is that the v12 of the package now uses a new API version which brings breaking changes in behavior as described in the API Upgrade Guide

@prathmesh-stripe Can you please update the changelog and the release tag https://github.com/stripe/stripe-ruby/releases/tag/v12.0.0? And re-open the internal ticket we have for this change to be included in the next major release?

@fschwahn
Copy link

@ramya-stripe thanks for clearing that up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants