Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new test target to skip stripe-mock dependent tests #672

Merged
merged 4 commits into from
Aug 25, 2020

Conversation

suz-stripe
Copy link
Contributor

👋
this PR proposes a workaround for #670

TLDR: anyone wishing to run basic test coverage on this codebase without having to install and run stripe-mock can run make test-nomock. This will run all tests which do not depend on stripe-mock.

A summary of the changes:

  • the original make test target make test is unchanged
  • a new make test-nomock target has been added
  • this new test command runs only the tests that do not rely on stripe-mock as a dependency
  • adds a new flag for pytest --nomock in order to skip tests that need stripe-mock
  • 136 tests can still be run without stripe-mock vs 483 which do require stripe-mock ∴ around ~22% of our tests.

@suz-stripe suz-stripe force-pushed the suz/no-mock-test-target branch from a6898ba to d8dab18 Compare August 25, 2020 16:48
@suz-stripe suz-stripe force-pushed the suz/no-mock-test-target branch from d8dab18 to dcbf331 Compare August 25, 2020 16:51
Copy link
Contributor

@richardm-stripe richardm-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@suz-stripe suz-stripe merged commit b05a7fc into master Aug 25, 2020
@suz-stripe suz-stripe deleted the suz/no-mock-test-target branch August 25, 2020 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants