Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade ruff version #1456

Merged
merged 3 commits into from
Feb 13, 2025
Merged

upgrade ruff version #1456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dbf38e7
upgrade ruff version
xavdid-stripe Feb 12, 2025
1cefa40
remove old comment
xavdid-stripe Feb 12, 2025
6750b17
update comment
xavdid-stripe Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion deps/dev-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,13 @@
# version requirements: any modern python version (currently 3.10)

# typechecking for all versions
# can't use `>=1.1.339` since it flags override issues, e.g.:
# > Method "_cls_delete" overrides class "DeletableAPIResource" in an incompatible manner Parameter "**params" has no corresponding parameter Pylance(reportIncompatibleMethodOverride)
# can probably fix/ignore these issues and move forward, but we're stuck until then
pyright == 1.1.336
# general typechecking
mypy == 1.7.0
# formatting
ruff == 0.4.4
ruff == 0.9.6
# linting
flake8
3 changes: 1 addition & 2 deletions stripe/_ephemeral_key.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,8 +147,7 @@ async def delete_async( # pyright: ignore[reportGeneralTypeIssues]
def create(cls, **params):
if params.get("stripe_version") is None:
raise ValueError(
"stripe_version must be specified to create an ephemeral "
"key"
xavdid-stripe marked this conversation as resolved.
Show resolved Hide resolved
"stripe_version must be specified to create an ephemeral key"
)

url = cls.class_url()
Expand Down
Loading