Add support for 'stripe_version' to File.create

stripe · Jul 13, 2020 · da1acf4 · da1acf4
1 parent 85df137
commit da1acf4
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 5 deletions.
diff --git a/stripe/api_resources/file.py b/stripe/api_resources/file.py
@@ -21,12 +21,19 @@ def class_url(cls):
 
     @classmethod
     def create(
-        cls, api_key=None, api_version=None, stripe_account=None, **params
+        # 'api_version' is deprecated, please use 'stripe_version'
+        cls,
+        api_key=None,
+        api_version=None,
+        stripe_version=None,
+        stripe_account=None,
+        **params
     ):
+        version = api_version or stripe_version
         requestor = api_requestor.APIRequestor(
             api_key,
             api_base=stripe.upload_api_base,
-            api_version=api_version,
+            api_version=version,
             account=stripe_account,
         )
         url = cls.class_url()
@@ -35,7 +42,7 @@ def create(
             "post", url, params=params, headers=supplied_headers
         )
         return util.convert_to_stripe_object(
-            response, api_key, api_version, stripe_account
+            response, api_key, version, stripe_account
         )
 
 

diff --git a/tests/api_resources/test_account_link.py b/tests/api_resources/test_account_link.py
@@ -7,8 +7,8 @@ class TestAccountLink(object):
     def test_is_creatable(self, request_mock):
         resource = stripe.AccountLink.create(
             account="acct_123",
-            failure_url="https://stripe.com/failure",
-            success_url="https://stripe.com/success",
+            refresh_url="https://stripe.com/failure",
+            return_url="https://stripe.com/success",
             type="custom_account_verification",
         )
         request_mock.assert_requested("post", "/v1/account_links")

diff --git a/tests/api_resources/test_file.py b/tests/api_resources/test_file.py
@@ -50,6 +50,26 @@ def test_is_creatable(self, setup_upload_api_base, request_mock):
         )
         assert isinstance(resource, stripe.File)
 
+    def test_create_respects_stripe_version(self, setup_upload_api_base, request_mock):
+        test_file = tempfile.TemporaryFile()
+        stripe.File.create(
+            purpose="dispute_evidence",
+            file=test_file,
+            stripe_version="foo"
+        )
+        request_mock.assert_api_version("foo")
+
+    # You can use api_version instead of stripe_version
+    # in File.create. We preserve it for backwards compatibility
+    def test_create_respects_api_version(self, setup_upload_api_base, request_mock):
+        test_file = tempfile.TemporaryFile()
+        stripe.File.create(
+            purpose="dispute_evidence",
+            file=test_file,
+            api_version="foo"
+        )
+        request_mock.assert_api_version("foo")
+
     def test_deserializes_from_file(self):
         obj = stripe.util.convert_to_stripe_object({"object": "file"})
         assert isinstance(obj, stripe.File)