-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose StripeResource on instance #920
Conversation
re-assigning to @richardm-stripe to both approve but also clarify if this should be done in the codegen part instead of here. |
I think it additionally needs a change to one of the preambles in the TS codegen stuff; not certain though. |
I mean, users will get a type error if they try to use it and we don't add such a type. The problem is, the type of We could just type it as |
Hey @richardm-stripe! I think in this case it's just a matter of adding |
Merging this without a typedef for now. (I don't think there's much advantage to adding StripeResource: any over omitting the typedef altogether) |
…-instance Expose StripeResource on instance
…-instance Expose StripeResource on instance
r? @stripe/api-libraries
cc @stripe/api-libraries @remi-stripe @paulasjes-stripe
This just surfaces the
StripeResource
on the instance as well, so you can continue to doconst stripe = require('stripe')(apiKeyHere);
but still be able to add resources while working with beta things.