-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#857 Allow default stripeAccount in options #1102
Conversation
…option stripe#857 add default option for stripeAccount
fixes #857 |
i'd really like to see this feature land -- otherwise it's too perilous to manually ensure large groups of stripe calls are attaching the correct things will be safer once we can preconfigure the stripe account header for whole systems, that way, none of the individual stripe calls can make such a simple mistake :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I took the liberty of writing a test in a separate PR and will hopefully merge both soon!
Thanks @richardm-stripe |
Co-authored-by: lyndonbuckley <[email protected]>
Co-authored-by: lyndonbuckley <[email protected]>
This is a pretty minor code change allowing a new option in the StripeConfig interface stripeAccount
When building an API request, the Stripe-Account header is now added to the default request headers.
fixes #857