Fixes compilation and running from within VS Code #1902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ld and run from vs code: - added missing package to StripeRequestTest - increased the language server per-thread stack size (Xss) to 8m so lombok can run - added eclipse access rule for com.sun.net.httpserver.* so the langauge server does not report them as errors to the debugger
xavdid-stripe
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
stripe-java uses Lombok to generate getters and setters for class properties, and recently it stopped working correctly when developing in vscode. The logs indicate a StackOverflowError when the language server is running Lombok. When troubleshooting that, I also noticed that using "restricted" httpserver imports in ThinEventWebhookHandler would cause a quiet error when trying to run any java files from vscode. These imports are technically "restricted" but are supported as exported APIs by the JDK team. All of these made it very difficult to debug or run java files from within vscode. This PR fixes these issues by increasing the language server stack size and explicitly defining an access rule for that vscode-java can use the httpserver imports.
What?