Detect errors when creating a Source in the 3DS example #936
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reporting errors creating the Source, and fixing crash that happens when
source.cardDetails == nil
.Motivation
Two problems:
error
was never being checked and reportedsource
orsource.cardDetails
isnil
,source.cardDetails.threeDSecure == STPSourceCard3DSecureStatusRequired
because
STPSourceCard3DSecureStatusRequired == 0
and Obj-C'snil
-> 0 conversion.This resulted in passing a
nil
card id into thethreeDSecureParamsWithAmount:...
method,which crashed when it tried to put it into an
NSDictionary
Testing
This is the example code, so it doesn't have automated testing. Manually tested by using
a livemode publishable key (
pk_live_...
) and the auto-filled test card #, whichcauses the initial Source creation to fail: