Fix crash when hostViewController is set to a UINavController #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mludowise-stripe
pushed a commit
that referenced
this pull request
Mar 2, 2022
* Add instant debit mandate * Use calculated line spacing * Cleanup * Add snapshot test * Fix build * Cleanup * Rename property * Fix animation glitch * Fix iOS 12 test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @joeydong-stripe
Currently if you set
paymentContext.hostViewControllerto a navigation controller and push any of our view controllers onto its stack, the SDK will crash when dismissing because it callspopToViewController:with the parent UINavigationController (which of course isn't in its own stack).In this fix, we save the top VC on the stack if you set
hostViewControllerto a navigation controller, and pop to that VC when dismissing.