Add client-side metadata charge_request_id to requests to example-ios-backend
#1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ios-backend` The value is meaningless, it's just a randomly generated UUID `B3E611D1-5FA1-4410-9CEC-00958A5126CB`. However, along with the changes from stripe/example-mobile-backend#35, this shows off some of what `metadata` can be used for. I am *not* adding metadata to each location where the Stripe API is directly used, only the places that go through stripe/example-ios-backend. Many of the places that directly deal with the stripe-ios SDK could *also* add metadata. That's being omitted for simplicity. See also IOS-356
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The sample apps are now sending a (meaningless) randomly generated UUID value through
stripe/example-ios-backend as metadata from the client.
charge_request_id: B3E611D1-5FA1-4410-9CEC-00958A5126CBAlso updating all of our links to the example-ios-backend to use the latest release
that includes support for this feature.
Motivation
IOS-356
Along with the changes from stripe/example-mobile-backend#35, this shows off some of what
metadatacan be used for.Testing
Ran each of the sample apps, created Charges and a PaymentIntent, and then manually
verified the metadata was associated with the newly created Payments in the web dashboard.
We don't have automated testing of the sample apps, and this doesn't change the SDK.