[wip] Add support for unsettable fields

[ob-stripe]

No description provided.

[remi-stripe]

Added some comment. What does this change look like in VSCode and other IDE for .NET? How confusing/clear are the docstrings/helper?

[remi-stripe]

I am fairly sure you can never unset a default source. If the openapi spec says otherwise, the spec is wrong.

[ob-stripe]

I copied this from stripe-java, so the spec is likely wrong.

[remi-stripe]

Does it make sense to support this on string since you can simply pass an empty string today and it just works?

[ob-stripe]

That's certainly debatable. Is this:

var options = new CustomerUpdateOptions { Email = EmptyParam.Empty };

better/clearer than this:

var options = new CustomerUpdateOptions { Email = "" };
// or even
var options = new CustomerUpdateOptions { Email = string.Empty };

?

In stripe-java we do define an overload with EmptyParam even for strings, but we disallow empty strings, which we don't do in stripe-dotnet.

Let's discuss this with @cjavilla-stripe and @richardm-stripe next week.

[clement911]

Will this fix #1954 and allow setting fields to null?

Wouldn't EmptyParam.Empty be better named NullParam.Null since it's setting to null and not empty string?
This will work with other types such as long, DateTime, bool too right? If so, the rename would even make more sense because in .net we talk about a nullable long, not an empty long (for example).

What do you think?

[ob-stripe]

Will this fix #1954 and allow setting fields to null?

As long as the field can be unset on the API's side, yes. That's not the case for all fields.

Wouldn't EmptyParam.Empty be better named NullParam.Null since it's setting to null and not empty string?

Technically there isn't really a difference. Because Stripe's API uses form-encoding for requests, there isn't an explicit notion of "null" -- if you unset a field named foo, the encoded request body will look like foo=.

That said that's more of an implementation detail and I agree that EmptyParam.Empty might not be the best name. We'll take this into consideration. Thanks for the feedback!

[clement911]

Technically there isn't really a difference. Because Stripe's API uses form-encoding for requests, there isn't an explicit notion of "null" -- if you unset a field named foo, the encoded request body will look like foo=.

That said that's more of an implementation detail and I agree that EmptyParam.Empty might not be the best name.

Indeed that sounds like an implementation detail.

Consider the fact that if you set foo= and load foo back from the API, the API would return null and not "". If I understand correctly...

[CLAassistant]

All committers have signed the CLA.

[ob-stripe]

Closing due to staleness.