Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Remove the jar file option"" #5

Merged
merged 1 commit into from
Jan 21, 2021

Conversation

hibariya
Copy link
Collaborator

@hibariya hibariya commented Jan 19, 2021

I've investigated the failed CIs for the following pull requests.

As I mentioned on #4, currently, we cannot run CI on forked repositories, and perhaps that's the reason for these failures. I'd like to investigate that as a separate issue.

As for removing jar options, I assume that this and the other pull requests above will run without problems after merged. To make sure there are not any other major issues, I want to run the new CI on a topic branch of the upstream repository. Could you push this temporary branch to stripe-samples/checkout-single-subscription? The branch will use this branch (3-revert-2-jar) as sample-ci.

# like this:
git remote add hibariya https://github.com/hibariya/checkout-single-subscription.git
git fetch hibariya
git push origin hibariya/jar-verify jar-verify

@cjavilla-stripe cjavilla-stripe merged commit 15a2a0e into master Jan 21, 2021
@cjavilla-stripe
Copy link
Contributor

Worked for the subscription-use-cases repo! Going to try the others now.

@hibariya
Copy link
Collaborator Author

Thanks! Could you also check this one? stripe-archive/accept-a-card-payment#61

@cjavilla-stripe
Copy link
Contributor

yeah I missed that one :) will merge now.

@hideokamoto-stripe hideokamoto-stripe deleted the revert-3-revert-2-jar branch September 20, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants